Skip to content
This repository has been archived by the owner on Oct 23, 2019. It is now read-only.

Fix 'NoneType' guess_extension exception #88

Merged
merged 2 commits into from
Oct 9, 2018
Merged

Fix 'NoneType' guess_extension exception #88

merged 2 commits into from
Oct 9, 2018

Conversation

brokeyourbike
Copy link
Contributor

For the issue #87

@brokeyourbike brokeyourbike mentioned this pull request Oct 8, 2018
Closed
Lonami
Lonami suggested changes Oct 8, 2018
View reviewed changes
Copy link
Collaborator

@Lonami Lonami left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would rather get the mimetype for the empty string '' over 'None'. I don't think str(mime) is the way to go. Maybe a simple if not mime: return '.bin' or no extension at all.

@brokeyourbike
Update utils.py
ee33c85 
I'm not sure if this is the right way to fix this, coz I don't have such experience in python.
@brokeyourbike
Copy link
Contributor Author

I'm not sure if this is the right way to fix this, coz I don't have such experience in python. Please take a look.

@Lonami Lonami merged commit f4e009b into expectocode:master Oct 9, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Lonami Lonami Lonami requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@brokeyourbike @Lonami